---
title: Review the contribution pipeline for gaps, defects and simplifications
type: task
status: completed
description: >-
  End-to-end review of the ██████ ████████████ ████████ (design doc, extension/contribution,
  cli/league wiring) to surface defects, decision loops, stale limits and simplifications, fixing
  small ones in-session.
base_uri: user:task/league/review-contribution-pipeline-for-gaps-and-simplifications.md
created_at: '2026-10-29T16:01:47.129Z'
entity_id: 2f44fe52-a98c-4ea5-9599-26b50f67354e
finished_at: '2026-10-29T16:29:20.558Z'
observations:
  - ████████████████████████████████████████████████
  - ████████████████████████████████████████████████
  - ████████████████████████████████████████████████
  - ████████████████████████████████████████████████
  - ████████████████████████████████████████████████
  - ████████████████████████████████████████████████
  - ████████████████████████████████████████████████
  - ████████████████████████████████████████████████
owner_identity_uri: █████████████████████████
priority: Medium
public_read: true
relations:
  - relates [[██████████████████████-████████████-███████████]]
tags:
  - user:tag/league-xo-football.md
updated_at: '2026-10-29T16:29:20.558Z'
visibility_analyzed_at: '2026-11-05T23:50:15.661Z'
---

## Ask

Review the ██████ ████████████ ████████ end to end and surface gaps, defects, simplifications and improvements. Fix what is small and clearly in scope; plan the rest here.

## Context

- Design: [[user:text/league/contribution-pipeline.md]] (over its 43,000-byte Read budget; a pre-commit guard refuses growth, so the review should also prune it).
- Code: `extension/contribution/` (host jobs, decision requests, diff gate, diff review, publish) and the `cli/league/` wiring scripts.
- Runs on ████████████; land runs on the macbook.

## Plan

- [x] Read the design doc and the extension; map each stage (intake, plan, plan review, implement, diff review, publish, land, ship, reconcile) to its code and tests.
- [x] Audit operator decision requests for loops: any hold whose recommended choice deterministically reproduces the same hold.
- [x] Audit size and budget limits (diff review cap, unanswered review budget, stall clocks) against real contribution history in `contribution_pipeline_events`.
- [x] List simplifications: dead or retired refusal reasons, duplicated rules between code and doc, transitional cruft.
- [x] Record findings as observations here; fix small defects in-session; write follow-up tasks only for multi-session work.

## Known findings

- 2026-10-29: contribution 3a5e86f4 was held four times as "never checked" because one-line edits to single-line query snapshots made the review diff 264,000 characters; the hold kept recommending a re-review that could not succeed. Fixed in user-base `bed52ada04` (long changed lines compacted for the reviewer; too-large holds recommend the orchestrator lane).
